Change in vdsm[ovirt-3.3]: VDSM now writes its version number in VDSM-generated ifcfg f...

danken at redhat.com danken at redhat.com
Sun Aug 4 18:49:46 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: VDSM now writes its version number in VDSM-generated ifcfg files
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 180:         self._removeSourceRouteFile('rule', device)
Line 181:         self._removeSourceRouteFile('route', device)
Line 182: 
Line 183: 
Line 184: class ConfigWriter(object):
You are perfectly right. I thought of the unused CONFFILE_HEADER only after merging http://gerrit.ovirt.org/17566 .

http://ekohl.nl/vdsm/2013/%23vdsm.08-01.log

 17:44 <@danken1> grr, why have I taken amuller's latest patch. I forgot about CONFFILE_HEADER
 17:51 < apuimedo> danken1: ?
 17:52 < apuimedo> you took the patch I -1?
 17:52 < apuimedo> ah no
 17:52 < apuimedo> which then?
 17:53 < apuimedo> danken1: that's funny
 17:53 < apuimedo> now we have the unused constant be replaced :P
Line 185:     CONFFILE_HEADER = '# automatically generated by vdsm'
Line 186:     DELETED_HEADER = '# original file did not exist'
Line 187: 
Line 188:     def __init__(self):


-- 
To view, visit http://gerrit.ovirt.org/17612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida8a540356e04d86eb19e05149861d800d8f7313
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list