Change in vdsm[master]: tests: setupNetworks with invalid params.

asegurap at redhat.com asegurap at redhat.com
Sun Aug 4 09:48:08 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: setupNetworks with invalid params.
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File tests/netmodelsTests.py
Line 59:             self.assertEqual(cneContext.exception.errCode,
Line 60:                              neterrors.ERR_BAD_BRIDGE)
Line 61: 
Line 62:     def testIsNicValid(self):
Line 63:         invalidNicName = ('toni', 'livnat', 'dan')
You will laugh, but I have a test VM in which the names are:
"igor", "toni", "dan" and "livnat".
Line 64: 
Line 65:         class FakeNetInfo(object):
Line 66:             def __init__(self):
Line 67:                 self.nics = ['eth0', 'eth1']


-- 
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77b3a9c0d84e38e8b9060191b138c3e09104dc6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list