Change in vdsm[ovirt-3.3]: Add support for direct setting of cpu_shares when creating a...

ybronhei at redhat.com ybronhei at redhat.com
Sun Aug 4 06:33:10 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Add support for direct setting of cpu_shares when creating a VM
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/vm.py
Line 2808: 
Line 2809:         # if cpu_shares weren't configured we derive the value from the
Line 2810:         # niceness, cpu_shares has not unit, it is only meaningful when
Line 2811:         # compared to other VMs (and can't be negative)
Line 2812:         cpu_shares = int(self.conf.get('cpuShares', str((20 - nice) * 51)))
if you already change this code, please add comment that explains this equation
Line 2813:         cpu_shares = max(cpu_shares, 0)
Line 2814: 
Line 2815:         try:
Line 2816:             self._dom.setSchedulerParameters({'cpu_shares': cpu_shares})


-- 
To view, visit http://gerrit.ovirt.org/17603
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ef73cf0579a0efd5a31c32638efcc6cdf2447d7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list