Change in vdsm[master]: Fix log level for failures in execCmd

danken at redhat.com danken at redhat.com
Sat Aug 3 18:40:33 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Fix log level for failures in execCmd
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

Saggi, what is your "logErr" arg for, then? We could flip its default if you insist.

Sergey, this patch is based on a 3 month old HEAD. Please rebase.

....................................................
File vdsm/storage/misc.py
Line 238:         # Prevent splitlines() from barfing later on
Line 239:         out = ""
Line 240: 
Line 241:     if p.returncode != 0 and logErr:
Line 242:         execCmdLogger.warning("FAILED: <err> = %s; <rc> = %d", repr(err),
using %r is so much cooler than calling repr().
Line 243:                               p.returncode)
Line 244:     else:
Line 245:         execCmdLogger.debug("%s: <err> = %s; <rc> = %d",
Line 246:                             {True: "SUCCESS", False: "FAILED"}


-- 
To view, visit http://gerrit.ovirt.org/13362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5c3ac5bde06ed9083bc9c1662d3b4eddc85034
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list