Change in vdsm[master]: tests: setupNetworks add one or more vlans.

gvallare at redhat.com gvallare at redhat.com
Fri Aug 2 18:46:35 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: tests: setupNetworks add one or more vlans.
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File tests/functional/networkTests.py
Line 347:     @RequireDummyMod
Line 348:     @ValidateRunningAsRoot
Line 349:     def testSetupNetworksAddManyVlans(self, bridged):
Line 350:         VLAN_COUNT = 5
Line 351:         NET_VLANS = [(NETWORK_NAME + str(id), str(id))
Done
Line 352:                      for id in xrange(VLAN_COUNT)]
Line 353: 
Line 354:         with dummyIf(1) as nics:
Line 355:             nic = nics[0]


Line 348:     @ValidateRunningAsRoot
Line 349:     def testSetupNetworksAddManyVlans(self, bridged):
Line 350:         VLAN_COUNT = 5
Line 351:         NET_VLANS = [(NETWORK_NAME + str(id), str(id))
Line 352:                      for id in xrange(VLAN_COUNT)]
Done
Line 353: 
Line 354:         with dummyIf(1) as nics:
Line 355:             nic = nics[0]
Line 356:             networks = dict((vlan_net,


Line 351:         NET_VLANS = [(NETWORK_NAME + str(id), str(id))
Line 352:                      for id in xrange(VLAN_COUNT)]
Line 353: 
Line 354:         with dummyIf(1) as nics:
Line 355:             nic = nics[0]
well dummyIf is called with 1... But I can save you the [0] since I'm updating this patch...
Line 356:             networks = dict((vlan_net,
Line 357:                              {'vlan': str(tag), 'nic': nic,
Line 358:                               'bridged': bridged})
Line 359:                             for vlan_net, tag in NET_VLANS)


Line 368:                     self.assertTrue(self.vdsm_net.vlanExists(nic + '.' + tag))
Line 369: 
Line 370:             with self.vdsm_net.pinger():
Line 371:                 for vlan_net, tag in NET_VLANS:
Line 372:                     status, msg = self.vdsm_net.setupNetworks(
Makes sense.
Line 373:                         {vlan_net: {'remove': True}}, {}, {})
Line 374:                     self.assertEqual(status, SUCCESS, msg)
Line 375:                     self.assertFalse(self.vdsm_net.networkExists(vlan_net,
Line 376:                                                                  bridged))


-- 
To view, visit http://gerrit.ovirt.org/17432
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62fa6de1faa7d4e886c45361a001b0009fd92502
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list