Change in vdsm[master]: Crash fix for migrations that involve devices with no aliase...

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Aug 2 13:40:28 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: Crash fix for migrations that involve devices with no aliases
......................................................................


Patch Set 1:

Yes it is not beautiful however it will avoid our issue. There's no other real generic way to fix this, except we would be applying the 'getUnderlying' code on the received _srcDomXML

I could modify the getUnderlying methods that way that they get the parsed domXml object and additionally conf and devices to update them. If this is in your mind. However this is rather a bigger reconstruction than a quick fix.

For now I have added http://gerrit.ovirt.org/#/c/17602/ to solve this issue.

-- 
To view, visit http://gerrit.ovirt.org/17515
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f05a945c2f3507d5571ac3f3b212e59a30bdfae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list