Change in vdsm[master]: ClientIF: avoid runtime errors at VM shutdown
sbonazzo at redhat.com
sbonazzo at redhat.com
Fri Aug 2 12:42:29 UTC 2013
Sandro Bonazzola has posted comments on this change.
Change subject: ClientIF: avoid runtime errors at VM shutdown
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/clientIF.py
Line 133: else:
Line 134: if not self.domainVmIds[dom]:
Line 135: domainsToRemove.append(dom)
Line 136: with self.domainVmIdsLock:
Line 137: for dom in domainsToRemove:
You can't do the collection at first loop and removal and del at second loop: without the removal at first loop you'll not have empty domains to del at second.
I don't know vdsm enough to say if the remove from all existing domains can be done within a single lock acquisition. I assumed that the above comment was placed there for a good reason.
Line 138: del self.domainVmIds[dom]
Line 139:
Line 140: def contEIOVms(self, sdUUID, isDomainStateValid):
Line 141: # This method is called everytime the onDomainStateChange
--
To view, visit http://gerrit.ovirt.org/17599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e39f777ce914b8b038505969767b6fd3ff9072f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list