Change in vdsm[master]: ClientIF: avoid runtime errors at VM shutdown

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri Aug 2 11:31:33 UTC 2013


Michal Skrivanek has posted comments on this change.

Change subject: ClientIF: avoid runtime errors at VM shutdown
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/clientIF.py
Line 122:                     self.domainVmIds[dom] = set([vmId])
Line 123: 
Line 124:     def removeVmFromMonitoredDomains(self, vmId):
Line 125:         for dom in self.domainVmIds.keys():
Line 126:             #only take lock here to allow runVm to take the lock in-between
is this actually useful for anything? iterating over a list with simple ids should be relatively fast and hence no reason to not to take a lock for the whole operation
Line 127:             with self.domainVmIdsLock:
Line 128:                 try:
Line 129:                     self.domainVmIds[dom].remove(vmId)
Line 130:                 except ValueError:


-- 
To view, visit http://gerrit.ovirt.org/17599
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e39f777ce914b8b038505969767b6fd3ff9072f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list