Change in vdsm[master]: Management network is now kept in main routing table

asegurap at redhat.com asegurap at redhat.com
Thu Aug 1 13:49:37 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Management network is now kept in main routing table
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 186:             for nic in nics:
Line 187:                 _validateInterNetworkCompatibility(_netinfo, vlan, nic,
Line 188:                                                    bridged)
Line 189: 
Line 190:     options['DEFROUTE'] = 'yes' if isManagementNetwork(network) else 'no'
I'd rather have lib/vdsm/constants.py have VDSMBRIDGE which is auto replaced by configure.ac and this check be:

options['DEFROUTE'] = 'yes' if network == constants.VDSMBRIDGE else 'no'
Line 191: 
Line 192:     logging.info("Adding network %s with vlan=%s, bonding=%s, nics=%s,"
Line 193:                  " bondingOptions=%s, mtu=%s, bridged=%s, options=%s",
Line 194:                  network, vlan, bonding, nics, bondingOptions,


-- 
To view, visit http://gerrit.ovirt.org/17575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55c50269dd3d52fd058951200282c925a7014aca
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list