Change in vdsm[master]: infra: Add logging in case PoolHandler crashes

ybronhei at redhat.com ybronhei at redhat.com
Thu Aug 1 11:59:00 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: infra: Add logging in case PoolHandler crashes
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/storage/remoteFileHandler.py
Line 216:         self.close()
Line 217: 
Line 218: 
Line 219: class PoolHandler(object):
Line 220:     log = logging.getLogger("RepoFileHelper.PoolHandler")
Repo? should be "remoteFileHandler.PoolHandler" for clearance
Line 221: 
Line 222:     def __init__(self):
Line 223:         myRead, hisWrite = os.pipe()
Line 224:         hisRead, myWrite = os.pipe()


-- 
To view, visit http://gerrit.ovirt.org/14626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie488886a608a6855019d4c36eb2b31c9a941f8c8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list