Change in vdsm[master]: gluster: move exportToSupervdsm at module level

abaron at redhat.com abaron at redhat.com
Mon Apr 29 20:22:08 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: gluster: move exportToSupervdsm at module level
......................................................................


Patch Set 14: (1 inline comment)

....................................................
File vdsm/gluster/__init__.py
Line 22: 
Line 23: MODULE_LIST = ('cli',)
Line 24: 
Line 25: 
Line 26: def exportToSuperVdsm(func):
by 'user' I mean user of your API, i.e. whoever consumes it.  In this case, supervdsm is consuming it.
The method should not be tightly coupled with supervdsm (which is a specific implementation) but just provide a list of public method.
Line 27:     @wraps(func)
Line 28:     def wrapper(*args, **kwargs):
Line 29:         return func(*args, **kwargs)
Line 30: 


--
To view, visit http://gerrit.ovirt.org/13051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8217899a637a10c7bc47a13e8afdddc1b0fefe
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list