Change in vdsm[master]: Update device hooks: Added before and after update device ho...
danken at redhat.com
danken at redhat.com
Mon Apr 29 09:18:52 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: Update device hooks: Added before and after update device hooks.
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1659: try:
Line 1660: try:
Line 1661: vnicXML = hooks.before_update_device(
Line 1662: vnicXML.toprettyxml(encoding='utf-8'), self.conf)
Line 1663: self._dom.updateDeviceFlags(vnicXML,
You should not create the dev obj as it already exists. It is one of the args. You should update its _deviceXML.
Line 1664: libvirt.VIR_DOMAIN_AFFECT_LIVE)
Line 1665: self.log.debug("Nic has been updated:\n %s" % vnicXML)
Line 1666: hooks.after_update_device(vnicXML, self.conf)
Line 1667: except Exception as e:
--
To view, visit http://gerrit.ovirt.org/13972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fe7f5e6d8291cc227a323b324c977bcd5bc8295
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list