Change in vdsm[master]: Supervdsm tests: Fail tests When supervdsm does not start as...

danken at redhat.com danken at redhat.com
Sun Apr 28 09:43:45 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Supervdsm tests: Fail tests When supervdsm does not start as expected
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File tests/superVdsmTests.py
Line 21:     return pyPath
Line 22: 
Line 23: 
Line 24: def monkeyLaunch(self):
Line 25:     self._firstLaunch = False
This function is just like the original launch, with _start() inlined, and panic() changed to assert.

Wouldn't it be nicer to monkey-patch _start and panic()?
panic() should be monkey-patched for ALL tests, probably.
Line 26:     self._authkey = str(uuid.uuid4())
Line 27:     self._log.debug("Launching Super Vdsm")
Line 28: 
Line 29:     superVdsmCmd = [getNeededPythonPath(), constants.EXT_PYTHON,


Line 31:                     self._authkey, str(os.getpid()),
Line 32:                     self.pidfile, self.timestamp, self.address,
Line 33:                     str(os.getuid())]
Line 34:     p = misc.execCmd(superVdsmCmd, sync=False, sudo=True)
Line 35:     p.wait(2)
shouldn't this error checking be pushed to the real _start()?
Line 36:     if p.returncode:
Line 37:         raise AssertionError('executing supervdsmCmd failed')
Line 38: 
Line 39:     try:


--
To view, visit http://gerrit.ovirt.org/13878
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33a5564a8e67d70087fef83ae651e8729bdb59a5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list