Change in vdsm[master]: storage.misc: Move execCmd and its dependencies to vdsm.util...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Sat Apr 27 08:23:38 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: storage.misc: Move execCmd and its dependencies to vdsm.utils
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File lib/vdsm/utils.py
Line 185:         if endtime is not None:
Line 186:             timeout = max(0, endtime - time.time())
Line 187: 
Line 188: 
Line 189: class AsyncProc(object):
Hmm... I have the same feeling when I moved it..
Line 190:     """
Line 191:     AsyncProc is a funky class. It warps a standard subprocess.Popen
Line 192:     Object and gives it super powers. Like the power to read from a stream
Line 193:     without the fear of deadlock. It does this by always sampling all


--
To view, visit http://gerrit.ovirt.org/14221
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8fb42035b24bc915aaa700ab128580bdb609d9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list