Change in vdsm[master]: readlines - remove redundant pathExists check

danken at redhat.com danken at redhat.com
Sat Apr 27 04:11:56 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: readlines - remove redundant pathExists check
......................................................................


readlines - remove redundant pathExists check

fileSD -> readlines:
* The verification of path existence is redundant.
* Try to read the metadata file and handle an exception:
- If no such file: return an empty list.
- Else, raise the exception.

Change-Id: Id73f4bd177465f253eb4f65403b17ff7375e329c
Bug-Url: https://bugzilla.redhat.com/882667
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M vdsm/storage/fileSD.py
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Daniel Erez: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id73f4bd177465f253eb4f65403b17ff7375e329c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list