Change in vdsm[master]: readlines - remove redundant pathExists check
derez at redhat.com
derez at redhat.com
Fri Apr 26 13:15:13 UTC 2013
Daniel Erez has posted comments on this change.
Change subject: readlines - remove redundant pathExists check
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 122: return misc.stripNewLines(self._oop.directReadLines(
Line 123: self._metafile))
Line 124: except (IOError, OSError) as e:
Line 125: if e.errno != errno.ENOENT:
Line 126: self._log.error("Could not retrieve metadata file for "
I've tried to revoke permissions from the metadata file, the thrown exception indeed includes the relevant info [1]. I'm not sure if this the case for other exception errors.
Since the controversy is only about whether to log or not, I've divided the patch into two consecutive patches:
* 1. Actual fix (this patch).
* 2. Logging (http://gerrit.ovirt.org/14266).
[1] "[Errno 13] Permission denied: $metadata_path"
Line 127: "domain in path %s", self._metafile)
Line 128: raise
Line 129: return []
Line 130:
--
To view, visit http://gerrit.ovirt.org/13664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id73f4bd177465f253eb4f65403b17ff7375e329c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list