Change in vdsm[master]: Supervdsm as external service

ybronhei at redhat.com ybronhei at redhat.com
Thu Apr 25 09:38:31 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Supervdsm as external service
......................................................................


Patch Set 3: Verified

"""While we at it... I've done major cleanup to the engine service, so maybe you would like to take some examples... this will be closer to be able to run on other distributions."""

I took a look and saw that what you've done there can be fit to what this patch http://gerrit.ovirt.org/#/c/13701/ does.
This "tool" allows us to manage services without rely on specific service management, but I still need to cover all your patches to be sure.

"""The engine is currently running on sysvinit, systemd, openrc, debian, upstart.
See[1], most notably:
1. systemd, upstart and openrc are not forking daemon, as these infrastructures knows how to manage process tree.
2. In our case the vdsmd service should start directly using unprivileged account.
What we need are two parameters:
  --pidfile=FILE  pid file to use
  --background    Go into the background
While both are optional, and used when required, for example sysvinit uses --pidfile= and --background, while systemd does not use anything.
Service does not need to drop privileges (setuid) as it run within correct context.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=952297
"""
Currently my patch separates vdsmd to two services, the management of the services will be provided in external patch based on this one. I'll try to upload it asap.

--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list