Change in vdsm[master]: vdsm: Don't log irrelevant errors with level ERROR

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Apr 25 08:36:36 UTC 2013


Vinzenz Feenstra has uploaded a new change for review.

Change subject: vdsm: Don't log irrelevant errors with level ERROR
......................................................................

vdsm: Don't log irrelevant errors with level ERROR

libvirtconnection.get() wrapMethod logs unhandled libvirtErrors
as ERROR. However it's irrelevant at that point, therefore it
should log it only as DEBUG message.

Change-Id: I62c395734173a996bc8237d24b85f1bb32a0be35
Bug-Url: https://bugzilla.redhat.com/955593
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
---
M lib/vdsm/libvirtconnection.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/14226/1

diff --git a/lib/vdsm/libvirtconnection.py b/lib/vdsm/libvirtconnection.py
index cf22384..2c2bfb3 100644
--- a/lib/vdsm/libvirtconnection.py
+++ b/lib/vdsm/libvirtconnection.py
@@ -131,8 +131,9 @@
                                   ecode, edom)
                     cif.prepareForShutdown()
                 else:
-                    cif.log.exception('Unknown libvirterror: ecode: %d '
-                                      'edom: %d', ecode, edom)
+                    cif.log.debug('Unknown libvirterror: ecode: %d edom: %d '
+                                  'level: %d message: %s', ecode, edom,
+                                  e.get_error_level(), e.get_error_message())
                 raise
         wrapper.__name__ = f.__name__
         wrapper.__doc__ = f.__doc__


--
To view, visit http://gerrit.ovirt.org/14226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62c395734173a996bc8237d24b85f1bb32a0be35
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>


More information about the vdsm-patches mailing list