Change in vdsm[master]: readlines - remove redundant pathExists check

abaron at redhat.com abaron at redhat.com
Wed Apr 24 21:05:04 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: readlines - remove redundant pathExists check
......................................................................


Patch Set 4: No score

(1 inline comment)

Apparently logger name needs fixing

....................................................
File vdsm/storage/fileSD.py
Line 122:             return misc.stripNewLines(self._oop.directReadLines(
Line 123:                                       self._metafile))
Line 124:         except (IOError, OSError) as e:
Line 125:             if e.errno != errno.ENOENT:
Line 126:                 self._log.error("Could not retrieve metadata file for "
Because it saves time in debugging issues.  It took about 4 people and a lot of time to figure out that this is the issue without it, so I don't see how this is a spurious log message.
very few things are 'the end of the world', but not having the metadata file basically means something went quite awry with your domain.  you actually do want to know this...
Line 127:                                 "domain in path %s", self._metafile)
Line 128:                 raise
Line 129:             return []
Line 130: 


--
To view, visit http://gerrit.ovirt.org/13664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73f4bd177465f253eb4f65403b17ff7375e329c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list