Change in vdsm[master]: multipath: Remove unused 'deduceType' and MIXED_DEV

danken at redhat.com danken at redhat.com
Wed Apr 24 19:30:08 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: multipath: Remove unused 'deduceType' and MIXED_DEV
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File lib/vdsm/constants.py.in
Line 156: STRG_ISCSI_SESSION = "iscsi_session/"
Line 157: 
Line 158: # Connection types
Line 159: 
Line 160: UNKNOWN_CON = 0
somehow my comment did not make it to patchset 3:
we want to clear this file of the remaining storage-specific constants, not to add more to it. You may add them to the ugly little module storage.storageConstants if it makes any sense.


I'd love to see the three STRG_*SCSI_* constants moved into iscsi.py, too (in an separate patch).
Line 161: NFS_CON = 1
Line 162: FCP_CON = 2
Line 163: ISCSI_CON = 3
Line 164: LOCALFS_CON = 4


....................................................
File vdsm/storage/hsm.py
Line 1852:                            'devtype': dev.get("devtype", ""),
Line 1853:                            'pathstatus': dev.get("paths", []),
Line 1854:                            'pathlist': dev.get("connections", []),
Line 1855:                            'logicalblocksize': dev.get("logicalblocksize", ""),
Line 1856:                            'physicalblocksize': dev.get("physicalblocksize", "")}
did this pass pep8? it's ugly anyway..
Line 1857:                 for path in devInfo["pathstatus"]:
Line 1858:                     if 'hbtl' in path:
Line 1859:                         path["lun"] = path["hbtl"].lun
Line 1860:                         del path["hbtl"]


--
To view, visit http://gerrit.ovirt.org/13363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37a94c3d67641f1c78d8fbecd63cbf1480c6e1b0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list