Change in vdsm[master]: vdsm: [REFACTORING] libvirtvm.py bye bye

danken at redhat.com danken at redhat.com
Wed Apr 24 13:11:43 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: [REFACTORING] libvirtvm.py bye bye
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

I like this as a first step. However, it is very hard to certify that the code was copied properly. So please be tough with this patch during verification - the moved code is involved in practically everything.

....................................................
File vdsm/vm.py
Line 1: #
Line 2: # Copyright 2009-2011 Red Hat, Inc.
Why? There's probably 2008 code here too.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


Line 37: import hooks
Line 38: import kaxmlrpclib
Line 39: import libvirt
Line 40: import logging
Line 41: import os
Please split imports to three groups: stdlib, other libs, internal modules.
Line 42: import pickle
Line 43: import sampling
Line 44: import supervdsm
Line 45: import tempfile


--
To view, visit http://gerrit.ovirt.org/14203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab8e2bc264b2a03eb21263d9faee1f55db109c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>


More information about the vdsm-patches mailing list