Change in vdsm[master]: Added setupNetworks command to vdsClient
wudxw at linux.vnet.ibm.com
wudxw at linux.vnet.ibm.com
Wed Apr 24 05:45:06 UTC 2013
Mark Wu has posted comments on this change.
Change subject: Added setupNetworks command to vdsClient
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File client/vdsClient.py
Line 2374: 'nic=<nic>,vlan=<number>,STP=<yes|no>,'
Line 2375: 'bridged=<true|false>,bonding=<name>] '
Line 2376: '[bond=<name>,nics=<nic1+nic2+...>,'
Line 2377: 'options=<option>]',
Line 2378: 'Setup new configuration of networks and bonds.'
Any reason not using dict as argument? It could simply the option parsing code and improve its readability.
Line 2379: )),
Line 2380: 'addNetwork': (serv.do_addNetwork,
Line 2381: ('bridge=<bridge> [vlan=<number>] [bond=<bond>] '
Line 2382: 'nics=nic[,nic]',
--
To view, visit http://gerrit.ovirt.org/14132
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0578caf5b5d9c4a4fb4a43b273f3fe2bdff9b03d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Sebek <psebek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list