Change in vdsm[master]: Update device hooks: Added before and after update device ho...
danken at redhat.com
danken at redhat.com
Tue Apr 23 14:05:44 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: Update device hooks: Added before and after update device hooks.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
would you stack your patch on top of Assaf's http://gerrit.ovirt.org/#/c/13876/ ?
....................................................
File vdsm/libvirtvm.py
Line 1637: netDev, netConf, linkValue, network) as nic_updated:
Line 1638: with self.updatePortMirroring(netConf, netsToMirror):
Line 1639: return {'status': doneCode,
Line 1640: 'vmList': self.status(),
Line 1641: 'nicUpdated': nic_updated}
This changes the client-visible API. Which should not happen without good reason.
Line 1642: except (LookupError,
Line 1643: SetLinkAndNetworkError,
Line 1644: UpdatePortMirroringError) as e:
Line 1645: return {'status':
Line 1720: def updateDevice(self, params):
Line 1721: update = None
Line 1722: if params.get('deviceType') == vm.NIC_DEVICES:
Line 1723: update = self._updateInterfaceDevice(params)
Line 1724: nic_xml = update['nicUpdated']
'new_nic_xml' may be a better name than 'nicUpdated', and it should be dropped from the update dictionary, so as not to confuse clients.
Line 1725: self.log.debug("Nic has been updated:\n %s" % nic_xml)
Line 1726: hooks.after_update_device(nic_xml, self.conf)
Line 1727: else:
Line 1728: update = errCode['noimpl']
--
To view, visit http://gerrit.ovirt.org/13972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fe7f5e6d8291cc227a323b324c977bcd5bc8295
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list