Change in vdsm[master]: Supervdsm as external service

Alon Bar-Lev alonbl at redhat.com
Mon Apr 22 16:43:49 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Supervdsm as external service
......................................................................


Patch Set 2: (1 inline comment)

Nice! this is the right solution, I am glad we reached that conclusion...

While we at it... I've done major cleanup to the engine service, so maybe you would like to take some examples... this will be closer to be able to run on other distributions.

The engine is currently running on sysvinit, systemd, openrc, debian, upstart.

See[1], most notably:

1. systemd, upstart and openrc are not forking daemon, as these infrastructures knows how to manage process tree.

2. In our case the vdsmd service should start directly using unprivileged account.

What we need are two parameters:
  --pidfile=FILE  pid file to use
  --background    Go into the background

While both are optional, and used when required, for example sysvinit uses --pidfile= and --background, while systemd does not use anything.

Service does not need to drop privileges (setuid) as it run within correct context.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=952297

....................................................
File vdsm.spec.in
Line 765: %{_datadir}/%{vdsm_name}/mk_sysprep_floppy
Line 766: %{_datadir}/%{vdsm_name}/parted_utils.py*
Line 767: %{_datadir}/%{vdsm_name}/mkimage.py*
Line 768: %{_datadir}/%{vdsm_name}/supervdsm.py*
Line 769: %attr (755,root,root) %{_datadir}/%{vdsm_name}/supervdsmServer.py*
I don't think the attr is required if make install is correct.
Line 770: %{_datadir}/%{vdsm_name}/vmChannels.py*
Line 771: %{_datadir}/%{vdsm_name}/tc.py*
Line 772: %{_datadir}/%{vdsm_name}/vdsm
Line 773: %{_datadir}/%{vdsm_name}/vdsm-restore-net-config


--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list