Change in vdsm[master]: Added four new hook points for device migrations

danken at redhat.com danken at redhat.com
Sun Apr 21 15:39:40 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Added four new hook points for device migrations
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 3180:                 try:
Line 3181:                     device = self._lookupAllDevicesByAlias(alias)
Line 3182:                     device._deviceXML = deviceXML.toxml()
Line 3183:                 except (LookupError, AttributeError) as e:
Line 3184:                     self.log.error('>>> ' + e.message)
I do not understand why we should go on if "alias" was not found. And why you do not log exc_info.
Line 3185: 
Line 3186:     def waitForMigrationDestinationPrepare(self):
Line 3187:         """Wait until paths are prepared for migration destination"""
Line 3188:         # Wait for the VM to start its creation. There is no reason to start


--
To view, visit http://gerrit.ovirt.org/13876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12278b91102f9bc0f031c4605ebf8b43fcb1bd6f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list