Change in vdsm[master]: Retry MD reads when validating pool-domain membership.

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Apr 21 06:41:07 UTC 2013


Eduardo has posted comments on this change.

Change subject: Retry MD reads when validating pool-domain membership.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 497:     # TODO: Remove or rename this function.
Line 498:     @unsecured
Line 499:     def validatePoolSD(self, sdUUID):
Line 500:         if sdUUID not in self.getDomains():
Line 501:             self._metadata.invalidate()
invalidateMetadata will do nothing if the host is the SPM.
In most cases this is correct.
In this specific case we want to reload it anyway since we suspect an external change.

    def invalidateMetadata(self):

        if not self.spmRole == SPM_ACQUIRED:

            self._metadata.invalidate()
Line 502:             if sdUUID not in self.getDomains():
Line 503:                 raise se.StorageDomainNotMemberOfPool(self.spUUID, sdUUID)
Line 504:         return True
Line 505: 


--
To view, visit http://gerrit.ovirt.org/14013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c11e1a0ce70e85b17167af5613bf597b42717c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list