Change in vdsm[master]: Remove redundant domStatuses parameter from validateAttached...

ykaplan at redhat.com ykaplan at redhat.com
Thu Apr 18 12:56:35 UTC 2013


Yeela Kaplan has posted comments on this change.

Change subject: Remove redundant domStatuses parameter from validateAttachedDomain()
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 1101:         domainStatuses = self.getDomains()
Line 1102:         dom = sdCache.produce(sdUUID)
Line 1103:         # Avoid domain activation if not owned by pool
Line 1104:         self.validateAttachedDomain(dom)
Line 1105: 
Since you no longer use domainStatuses in validate, I would move 'domainStatuses = self.getDomains()' here.
Line 1106:         # Do nothing if already active
Line 1107:         if domainStatuses[sdUUID] == sd.DOM_ACTIVE_STATUS:
Line 1108:             return True
Line 1109: 


--
To view, visit http://gerrit.ovirt.org/14012
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3daea2fa5928dee18efdf6452b65fbc212eec54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list