Change in vdsm[master]: agent: XML Character filtering improvement

danken at redhat.com danken at redhat.com
Thu Apr 18 04:32:13 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: agent: XML Character filtering improvement
......................................................................


agent: XML Character filtering improvement

The filtering of invalid characters for XML documents must not be
performed on unicode strings but on the encoded utf-8 string.
If we do not do this we'll be missing out on filtering everything
what would destroy the XML documents.
If there has been found an invalid character in the UTF-8 string
it _may_ cause the message to be discarded due to UTF-8 decoding
errors. However we don't want invalid strings to come through any
way.

Updated the unit tests for reflecting the changes.

Change-Id: I21b970c8552b3f238c6bfe9271c5c5a37d40ea4d
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
---
M tests/guestIFTests.py
M vdsm/guestIF.py
2 files changed, 15 insertions(+), 17 deletions(-)

Approvals:
  Vinzenz Feenstra: Verified
  Dan Kenigsberg: Looks good to me, approved
  Vered Volansky: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/13809
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I21b970c8552b3f238c6bfe9271c5c5a37d40ea4d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list