Change in vdsm[master]: gluster: Added gluster hooks support

avishwan at redhat.com avishwan at redhat.com
Wed Apr 17 15:54:18 UTC 2013


Aravinda VK has posted comments on this change.

Change subject: gluster: Added gluster hooks support
......................................................................


Patch Set 22: (1 inline comment)

....................................................
File vdsm/gluster/exception.py
Line 397:     code = 4500
Line 398:     message = "Gluster Hook Exception"
Line 399: 
Line 400: 
Line 401: class GlusterHookListException(GlusterException):
Looks like, ovirt-engine uses these error codes to map respective error messages in UI. If we combine error code of Hook List, Hook enable then it will be very difficult to map the meaningful message in UI for each error types. 

For example: ovirt-engine patch which will use these error messages. 
http://gerrit.ovirt.org/#/c/13270/
Line 402:     code = 4501
Line 403:     message = "List gluster hook failed"
Line 404: 
Line 405: 


--
To view, visit http://gerrit.ovirt.org/9671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3918aa035d90967f1297dc7fadcf14b6a9385c45
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list