Change in vdsm[master]: Update device hooks:

danken at redhat.com danken at redhat.com
Wed Apr 17 12:06:20 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Update device hooks:
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1730:             nic_to_update = self._get_device(params['alias'])
Line 1731:             nic_xml = nic_to_update.getXML().toprettyxml(encoding='utf-8')
Line 1732: 
Line 1733:             self.log.debug('Nic to update: %s' % nic_xml)
Line 1734:             nic_xml = hooks.before_update_device(nic_xml, self.conf)
why are you duplicating code from _updateInterfaceDevice()?

you should not add another call to _dom.updateDeviceFlags(), only add hooks before and after the already existing call within setLinkAndNetwork().
Line 1735: 
Line 1736:             try:
Line 1737:                 self._dom.updateDeviceFlags(
Line 1738:                     nic_xml, libvirt.VIR_DOMAIN_AFFECT_LIVE)


--
To view, visit http://gerrit.ovirt.org/13972
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fe7f5e6d8291cc227a323b324c977bcd5bc8295
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list