Change in vdsm[master]: agent: XML Character filtering improvement

danken at redhat.com danken at redhat.com
Wed Apr 17 11:50:37 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: agent: XML Character filtering improvement
......................................................................


Patch Set 4: No score

(1 inline comment)

....................................................
File vdsm/guestIF.py
Line 325:             if err.errno == errno.EWOULDBLOCK:
Line 326:                 pass
Line 327: 
Line 328:     def _parseLine(self, line):
Line 329:         line = _filterXmlChars(line)
"precaution"? Do you have an example where both functions are ready?

Sorry - I do not understand the issue completely (but I do not want to delay your patch any further).
Line 330:         args = json.loads(line.decode('utf8'))
Line 331:         args = _filterObject(args)
Line 332:         name = args['__name__']
Line 333:         del args['__name__']


--
To view, visit http://gerrit.ovirt.org/13809
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21b970c8552b3f238c6bfe9271c5c5a37d40ea4d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list