Change in vdsm[master]: image: update the volume permissions when needed

fsimonce at redhat.com fsimonce at redhat.com
Wed Apr 17 09:39:03 UTC 2013


Federico Simoncelli has submitted this change and it was merged.

Change subject: image: update the volume permissions when needed
......................................................................


image: update the volume permissions when needed

Volumes leaves created in 2.2 did not have the group writeable bit
set. In order to be able to start VMs from old NFS volumes we need
to check (and eventually fix) the group permissions during the volume
preparation.

The code to address this issue was already present but commit 5a0b2c9
reintroduced the problem substituting the prepareVolume calls with
prepareImage.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=911417
Change-Id: I516d8240840e3aa32bd8074420e331b8dc4e6da7
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
M tests/fileUtilTests.py
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/fileUtils.py
M vdsm/storage/fileVolume.py
M vdsm/storage/image.py
M vdsm/storage/sd.py
7 files changed, 52 insertions(+), 18 deletions(-)

Approvals:
  Federico Simoncelli: Verified; Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/13331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I516d8240840e3aa32bd8074420e331b8dc4e6da7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list