Change in vdsm[master]: vdsm: Try to reconnect on vmchannel after errors

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Apr 17 08:55:52 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Try to reconnect on vmchannel after errors
......................................................................


Patch Set 16: (2 inline comments)

....................................................
File vdsm/guestIF.py
Line 202:         else:
Line 203:             self.log.error('Unknown message type %s', message)
Line 204: 
Line 205:     def stop(self):
Line 206:         if not self._stopped:
Done
Line 207:             self._stopped = True
Line 208:             try:
Line 209:                 self._channelListener.unregister(self._sock.fileno())
Line 210:             except socket.error as e:


Line 335:                 else:
Line 336:                     self._handleData(data)
Line 337:         except socket.error as err:
Line 338:             if err.errno is not errno.EWOULDBLOCK:
Line 339:                 result = False
Done
Line 340:         return result
Line 341: 
Line 342:     def _parseLine(self, line):
Line 343:         args = json.loads(line.decode('utf8'))


--
To view, visit http://gerrit.ovirt.org/11977
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b9418e39558d45c97e9545bc9ecc4935f004e
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Jason Dillaman <jdillama at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list