Change in vdsm[master]: vdsm-tool: add service management utilities

fsimonce at redhat.com fsimonce at redhat.com
Mon Apr 15 18:08:53 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: vdsm-tool: add service management utilities
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

Marking -1 for visibility.

....................................................
File lib/vdsm/tool/service.py
Line 238:                 errors[alt.func_name] = (rc, out, err)
Line 239:     raise RuntimeError("Tried all alternatives but failed:\n%s" % errors)
Line 240: 
Line 241: 
Line 242: @expose("service_start")
Please use the regular dash "-" instead of underscore "_" (e.g. check systemctl or any other daemon options, the dash is usually preferred). Same thing for all the other commands. Thanks.
Line 243: def service_start(srvName):
Line 244:     """
Line 245:     Start a system service
Line 246:     """


--
To view, visit http://gerrit.ovirt.org/13701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1cbcf5fd00bb1ec73c5970be012e294b3b4c55
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list