Change in vdsm[master]: vdsm: Try to reconnect on vmchannel after errors

vfeenstr at redhat.com vfeenstr at redhat.com
Mon Apr 15 14:25:40 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Try to reconnect on vmchannel after errors
......................................................................


Patch Set 15: (1 inline comment)

....................................................
File vdsm/guestIF.py
Line 328:             while not self._stopped:
Line 329:                 data = self._sock.recv(2 ** 16)
Line 330:                 # The connection is broken when recv returns no data
Line 331:                 # therefore we're going to set ourself to stopped state
Line 332:                 if data:
good catch, thanks
Line 333:                     self._stopped = True
Line 334:                     result = False
Line 335:                 else:
Line 336:                     self._handleData(data)


--
To view, visit http://gerrit.ovirt.org/11977
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b9418e39558d45c97e9545bc9ecc4935f004e
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Jason Dillaman <jdillama at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list