Change in vdsm[master]: vdsmd: do not swallow libvirt error

masayag at redhat.com masayag at redhat.com
Mon Apr 15 08:35:33 UTC 2013


Moti Asayag has posted comments on this change.

Change subject: vdsmd: do not swallow libvirt error
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
Commit Message
Line 9: Recently I've seen multiple cases of vdsm not starting up with a vague
Line 10: error "Failed to define network filters on libvirt", when the underlying
Line 11: issue was that libvirt has crashed.
Line 12: 
Line 13: It's better to have a line or two of log noise, in order to see that
I'm not sure it will be just a couple lines rather than a full stack trace.
However, getting more information for the failure cause is better then a generic message.
Line 14: libvirt could not have been reached.
Line 15: 
Line 16: Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef


--
To view, visit http://gerrit.ovirt.org/13909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a91061f52ec4eff24dd1e10f525fd3fed9185ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list