Change in vdsm[master]: vdsm: Delay desktop lock until we are sure it was a disconne...
vfeenstr at redhat.com
vfeenstr at redhat.com
Mon Apr 15 07:12:10 UTC 2013
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 3: (3 inline comments)
....................................................
Commit Message
Line 8:
Line 9: This is a hack to mitigate the issue of spice-gtk not respecting the
Line 10: configured secure channels. Spice-gtk is always connecting first to
Line 11: a non-secure channel and the server tells the client then to connect
Line 12: to a secure channel. However as a result of this we're getting events
Well the problem is that we cannot enforce that all users will have that fixed version. And I hate to have to tell an admin that he has to upgrade a few thousand clients of different types of systems to a specific version of spice-gtk. If I would be that admin I would seriously start thinking about moving on to a different solution...
I will add that link
Line 13: of false positive disconnects and we need to ensure that we're really
Line 14: having a disconnected client
Line 15: This timer is supposed to delay the call to lock the desktop of the
Line 16: guest. And only lock it, if it there was no new connect.
....................................................
File vdsm/vm.py
Line 48: WATCHDOG_DEVICES = 'watchdog'
Line 49: CONSOLE_DEVICES = 'console'
Line 50: SMARTCARD_DEVICES = 'smartcard'
Line 51:
Line 52: _DESKTOP_LOCK_TIMEOUT = 2
Done
Line 53:
Line 54: """
Line 55: A module containing classes needed for VM communication.
Line 56: """
Line 829: self.guestAgent.desktopLock()
Line 830:
Line 831: def onDisconnect(self, detail=None):
Line 832: self.conf['clientIp'] = ''
Line 833: # This is a hack to mitigate the issue of spice-gtk not respecting the
I wish there'd be a better way :( I am out of ideas.
Line 834: # configured secure channels. Spice-gtk is always connecting first to
Line 835: # a non-secure channel and the server tells the client then to connect
Line 836: # to a secure channel. However as a result of this we're getting events
Line 837: # of false positive disconnects and we need to ensure that we're really
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list