Change in vdsm[master]: sampling: a quick fix to make vdsm run again

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Apr 15 02:47:00 UTC 2013


Mark Wu has posted comments on this change.

Change subject: sampling: a quick fix to make vdsm run again
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

Dan,
Thanks for the quick fix!  The change from _ifids to nics_ should be included in the http://gerrit.ovirt.org/13839. It was included in this c506391442bc because of code rebase mistake. And I only verified the last patch of the series, and didn't find c506391442bc is not self-contained. 
I need take great care for code merge/rebase, especially for the case of moving code to new file. 

I apologize for the mistake!

--
To view, visit http://gerrit.ovirt.org/13902
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc993a6b1284345805455a63e3926bc2893d5874
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list