Change in vdsm[master]: stats: report the domain version

fsimonce at redhat.com fsimonce at redhat.com
Thu Apr 11 12:07:35 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: stats: report the domain version
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/storage/domainMonitor.py
Line 58:         # synchronous operation (e.g.: connectStoragePool, getInfo)
Line 59:         # we cannot risk to stop and wait for the iso domain to
Line 60:         # report its prefix (it might be unreachable).
Line 61:         self.isoPrefix = None
Line 62:         self.version = 0
It might be better to set this to None and not report the version when the domain is unreachable.
Line 63: 
Line 64:     def update(self, st):
Line 65:         for attr in self.__slots__:
Line 66:             setattr(self, attr, getattr(st, attr))


--
To view, visit http://gerrit.ovirt.org/13620
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88884356eefcd5040deccbf34eab271be8dbc522
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list