Change in vdsm[master]: vdsm: Delay desktop lock until we are sure it was a disconne...

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Apr 11 08:53:16 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/vm.py
Line 840:         # guest. And only lock it, if it there was no new connect.
Line 841:         # This is detected by the clientIp being set or not.
Line 842:         self._desktopLockTimer = threading.Timer(_DESKTOP_LOCK_TIMEOUT,
Line 843:                                                  self._timedDesktopLock)
Line 844:         self._desktopLockTimer.start()
Well invalidation with the timer would create much more problems and over complicate it. However I noticed that I am still remembering the timer object.

I have changed that. We don't mind multiple calls on desktop lock, however we would mind desktopLock to be called when a FP happened.
Line 845: 
Line 846:     def _rtcUpdate(self, timeOffset):
Line 847:         self.log.debug('new rtc offset %s', timeOffset)
Line 848:         self.conf['timeOffset'] = timeOffset


--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list