Change in vdsm[master]: getAllTasksList\Status with spUUID retrieves info only if ho...

danken at redhat.com danken at redhat.com
Wed Apr 10 19:05:52 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM
......................................................................


Patch Set 14: I would prefer that you didn't submit this

(1 inline comment)

marking with -1 for visibility.

....................................................
File vdsm/storage/hsm.py
Line 2053:         # To reduce the race we validate SPM status before and after retreiving
Line 2054:         # the task list.
Line 2055:         if spUUID:
Line 2056:             self.validateSPM(spUUID)
Line 2057:         allTasksStatus = self.taskMng.getAllTasksStatuses("spm")
Well, raising an exception if self.taskMng.getAllTasksStatuses("spm") took more than the spm contention time, is a nice idea.

But theoretically, Vdsm's response may stall over the wire after they are returned. Engine should close all pending connections to the old SPM before trying to select a new one.

If it does that, we do not even need the second self.validateSPM() below.
Line 2058:         if spUUID:
Line 2059:             self.validateSPM(spUUID)
Line 2060:         return dict(allTasksStatus=allTasksStatus)
Line 2061: 


--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list