Change in vdsm[master]: vdsm-tool: add service management utilities
danken at redhat.com
danken at redhat.com
Wed Apr 10 18:06:05 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: add service management utilities
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File lib/vdsm/tool/service.py
Line 29: from vdsm.tool import expose
Line 30: from vdsm.utils import CommandPath
Line 31:
Line 32:
Line 33: def execCmd(argv):
You have a point here, Yaniv.
Use your -1 powers to raise such questions to awareness.
Line 34: p = subprocess.Popen(argv, stdout=subprocess.PIPE,
Line 35: stderr=subprocess.PIPE)
Line 36: out, err = p.communicate()
Line 37: rc = p.returncode
--
To view, visit http://gerrit.ovirt.org/13701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1cbcf5fd00bb1ec73c5970be012e294b3b4c55
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list