Change in vdsm[master]: readlines - remove redundant pathExists check
smizrahi at redhat.com
smizrahi at redhat.com
Wed Apr 10 13:05:50 UTC 2013
Saggi Mizrahi has posted comments on this change.
Change subject: readlines - remove redundant pathExists check
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 123: self._metafile))
Line 124: except (IOError, OSError) as e:
Line 125: if e.errno != errno.ENOENT:
Line 126: raise
Line 127: self._log.warn("Could not retrieve metadata file for doamin in "
You should warn on the error flow
Line 128: "path %s", self._metafile)
Line 129: return []
Line 130:
Line 131: def writelines(self, metadata):
--
To view, visit http://gerrit.ovirt.org/13664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id73f4bd177465f253eb4f65403b17ff7375e329c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list