Change in vdsm[master]: Bond destroying

danken at redhat.com danken at redhat.com
Tue Apr 9 17:54:44 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Bond destroying
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

Yeela, do you have a clue by any chance?

....................................................
Commit Message
Line 7: Bond destroying
Line 8: 
Line 9: If there is deleted network with bond other than bond[0-4] and no
Line 10: other network is using that bond, the bond is destroyed. It prevents
Line 11: accumulation poorly named bonds.
"poorly named" bonds are not the problem.

The issue that we must keep bond0-4 for backward compatibility. But we do not want to accumulate any other bond.

Please fix the commit message to show that.
Line 12: 
Line 13: Change-Id: I0cd27f1ff9a62e202c3513e54df5481d1b72ed7c
Line 14: Bug-Url: https://bugzilla.redhat.com/928442


....................................................
File vdsm/configNetwork.py
Line 517:         self._backup(netinfo.NET_CONF_PREF + bonding)
Line 518:         self._removeFile(netinfo.NET_CONF_PREF + bonding)
Line 519:         if bonding not in ['bond0', 'bond1', 'bond2', 'bond3', 'bond4']:
Line 520:             with open(BONDING_MASTERS, 'w') as f:
Line 521:                 f.write("-%s\n" % bonding)
wouldn't ifdown(bonding) be enough? Isn't it required anyway?
Line 522: 
Line 523: 
Line 524:     def removeBridge(self, bridge):
Line 525:         ifdown(bridge)


--
To view, visit http://gerrit.ovirt.org/13752
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd27f1ff9a62e202c3513e54df5481d1b72ed7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list