Change in vdsm[master]: clientIF: rescan devices on failed hotplugDisk

ewarszaw at redhat.com ewarszaw at redhat.com
Tue Apr 9 03:02:40 UTC 2013


Eduardo has posted comments on this change.

Change subject: clientIF: rescan devices on failed hotplugDisk
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/clientIF.py
Line 275:                 drive['volumeInfo'] = res['info']
Line 276: 
Line 277:             # GUID drive format
Line 278:             elif "GUID" in drive:
Line 279:                 res = self.irs.getDevicesVisibility([drive["GUID"]])
You are using getDevicesVisibility() for issuing a devices rescan.
This can be costly and unnecessary if the dev is already known to multipath.
in addition simultaneous prepareVolumePath() calls should be considered.
Please issue getDevicesVisibility() only in case that  not os.path.exists(volPath)
Line 280:                 visibility = res['visible']
Line 281:                 if visibility[drive["GUID"]] is False:
Line 282:                     self.log.error("GUID: %s is not visible", drive["GUID"])
Line 283:                     raise vm.VolumeError(drive)


Line 276: 
Line 277:             # GUID drive format
Line 278:             elif "GUID" in drive:
Line 279:                 res = self.irs.getDevicesVisibility([drive["GUID"]])
Line 280:                 visibility = res['visible']
visibility is redundant.
Line 281:                 if visibility[drive["GUID"]] is False:
Line 282:                     self.log.error("GUID: %s is not visible", drive["GUID"])
Line 283:                     raise vm.VolumeError(drive)
Line 284: 


--
To view, visit http://gerrit.ovirt.org/13454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5252a8ba6bf76c9eda3588c665ad379da3e9cfc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list