Change in vdsm[master]: Remove unnecessary storage log messages from logs

vvolansk at redhat.com vvolansk at redhat.com
Mon Apr 8 10:07:20 UTC 2013


Vered Volansky has posted comments on this change.

Change subject: Remove unnecessary storage log messages from logs
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 446:                                                  LVM_ACTIVATION_NAMESPACE)
Line 447:         try:
Line 448:             rmanager.registerNamespace(lvmActivationNamespace,
Line 449:                                        lvmActivationFactory)
Line 450:         except KeyError:
Other than a programmer's error there's no other cause for KeyError there.
The KeyError log messages may indeed be often, as far as consisting of 60% plus of the messages log.
The current flow of events is that every time there's a need for a reference to the domain, we try to create it (asking for existence causes a race). Trying to create it sends this message, along with an instance to the object. This instance remains in the system for as long as the specific task within which it was asked for is running. Once this task ends, it releases the reference it has to the storage. This stems from the fact that storages' ids are persistent in the system, and until this whole thing is refactored, along with a reasonable caching system, this will remain the way to obtain the storage's instance.
Line 451:             pass
Line 452: 
Line 453:     @classmethod
Line 454:     def metaSize(cls, vgroup):


--
To view, visit http://gerrit.ovirt.org/13617
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0fa5ca50e4eb78d62fd3cdc8b09723486bcaa0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list