Change in vdsm[master]: readlines - remove redundant pathExists check

derez at redhat.com derez at redhat.com
Sun Apr 7 09:51:32 UTC 2013


Daniel Erez has uploaded a new change for review.

Change subject: readlines - remove redundant pathExists check
......................................................................

readlines - remove redundant pathExists check

fileSD -> readlines:
The verification of path existence is redundant.
If there's a problem with reading the metafile
we shouldn't hide it by returning an empty list.

Change-Id: Id73f4bd177465f253eb4f65403b17ff7375e329c
Bug-Url: https://bugzilla.redhat.com/882667
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M vdsm/storage/fileSD.py
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/13664/1

diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index 7cd5c0b..0a18dad 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -117,8 +117,6 @@
         self._oop = oop.getProcessPool(self._sdUUID)
 
     def readlines(self):
-        if not self._oop.fileUtils.pathExists(self._metafile):
-                return []
         return misc.stripNewLines(self._oop.directReadLines(self._metafile))
 
     def writelines(self, metadata):


--
To view, visit http://gerrit.ovirt.org/13664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id73f4bd177465f253eb4f65403b17ff7375e329c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>


More information about the vdsm-patches mailing list