Change in vdsm[master]: Device custom properties: Keep non-custom devices in domxml

danken at redhat.com danken at redhat.com
Sun Apr 7 08:32:24 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Device custom properties: Keep non-custom devices in domxml
......................................................................


Device custom properties: Keep non-custom devices in domxml

Bug fix for device custom properties feature: Previously only
devices with custom properties were added to the VM's domxml
because of stupidity. Now all devices are added and device
creation hooks are called only for devices with custom
properties.

Patch Sets 2-5:
Styling, naming.

Change-Id: Ifb4f9eb32bc58371cec66301275689660193447b
Signed-off-by: Muller <amuller at redhat.com>
---
M vdsm/libvirtvm.py
1 file changed, 17 insertions(+), 14 deletions(-)

Approvals:
  Assaf Muller: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb4f9eb32bc58371cec66301275689660193447b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list