Change in vdsm[master]: vdsm: fix Vm cleanup routine

danken at redhat.com danken at redhat.com
Sun Apr 7 08:23:57 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: fix Vm cleanup routine
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/vm.py
Line 1038:         self._cleanupDrives(drive)
Line 1039:         self._cleanupDrives(drive1, drive2, drive3)
Line 1040:         self._cleanupDrives(*drives_list)
Line 1041: 
Line 1042:         In the case when no drives given, clean up all drives
this is an awkward and complex semantics. I'd prefer a separate _cleanupFloppy() method.
Line 1043:         and also floppy.
Line 1044:         """
Line 1045:         if not drives:
Line 1046:             # touch Floppy only if no drives are given --


Line 1072:             pass
Line 1073: 
Line 1074:         utils.rmFile(self._guestSocketFile)
Line 1075: 
Line 1076:     def _cleanupState(self):
I do not see why this one-liner deserves a method.
Line 1077:         """
Line 1078:         Clean up state file[s]
Line 1079:         """
Line 1080:         utils.rmFile(self._recoveryFile)


--
To view, visit http://gerrit.ovirt.org/13610
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie355022866d008a83257b1b6e3a4226a07d34c2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list