Change in vdsm[master]: vdsm: Add after_vdsm_start hook

abaron at redhat.com abaron at redhat.com
Sun Apr 7 05:37:42 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: vdsm: Add after_vdsm_start hook
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/hooks.py
Line 221:     return _runHooksDir(None, 'before_vdsm_start', raiseError=False)
Line 222: 
Line 223: 
Line 224: def after_vdsm_start():
Line 225:     return _runHooksDir(None, 'after_vdsm_start', raiseError=False)
why raiseError=False?
Line 226: 
Line 227: 
Line 228: def after_vdsm_stop():
Line 229:     return _runHooksDir(None, 'after_vdsm_stop', raiseError=False)


....................................................
File vdsm/vdsmd.init.in
Line 511:     RETVAL=$?
Line 512:     [ "$RETVAL" -eq 0 ] && log_success_msg $"$prog start" || log_failure_msg $"$prog start"
Line 513:     [ "$RETVAL" -eq 0 ] && touch /var/lock/subsys/vdsmd
Line 514: 
Line 515:     python @VDSMDIR@/hooks.pyc after_vdsm_start
Placing the hook here means that vdsm has started but not necessarily that initialization has finished successfully.
I wonder if this shouldn't be at the end of clientIF.py: __init__
Line 516: }
Line 517: 
Line 518: stop() {
Line 519:     echo $"Shutting down vdsm daemon: "


--
To view, visit http://gerrit.ovirt.org/13543
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id02b2b7d091ffa0be57a3850fa97cdcd35778466
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list